Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default limits to more sensible values #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update default limits to more sensible values #120

wants to merge 1 commit into from

Conversation

loevgaard
Copy link

I have been annoyed by these default limits multiple times - maybe others have as well? :-)

@Roshyo
Copy link
Contributor

Roshyo commented Feb 15, 2022 •
edited
Loading

What do you think of having rather a config for defining all grids at once ?

Like:

sylius_grid:
    default_grids_limits: [50, 100, 200]

And then the individual grid definition would override this.
The thing is that the limits you consider as "more sensible" may not be the same for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loevgaard @Roshyo